Add new rules for brotli, socket and ip#59
Merged
Conversation
lucic71
force-pushed
the
rules
branch
4 times, most recently
from
5f28bd8 to
cd990ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more translated symbols for brotli (enum values + functions), socket (enums + macros), and ip (enums).
This is not straight forward because symbols like IPPROTO_TCP are defined as enum on Linux and macro on macOS. To handle this, I modified cpp_rule_preprocessor + mapper to match macros and VisitIntegerLiteral to emit the translated macro.
Because on one platform the symbol is an enum and on the other it's a macro, the AST of the translated program is also different. To be able to generate the same code on both platforms, I use
IsCastRedundantInRustto normalize(libc::IPPROTO_TCP as i32)(Linux) andlibc::IPPROTO_TCP(macOS) tolibc::IPPROTO_TCP. This uses the fact thatlibc::IPPROTO_TCPis already an i32 in Rust, so the cast is redundant.